hiroyuki-sato opened a new pull request, #46657:
URL: https://github.com/apache/arrow/pull/46657

   ### Rationale for this change
   
   We are trying to implement shellcheck on all sh files in #44748.
   
   ### What changes are included in this PR?
   
   * SC2034 For keep argument order, add skip shellcheck comment.
   * SC2086 check require quoting like `${download_url}` -> `"${download_url}"`.
   
   ```
   In ci/scripts/install_conda.sh line 30:
   version=$2
   ^-----^ SC2034 (warning): version appears unused. Verify use (or export if 
used externally).
   
   
   In ci/scripts/install_conda.sh line 37:
   wget -nv ${download_url} -O /tmp/installer.sh
            ^-------------^ SC2086 (info): Double quote to prevent globbing and 
word splitting.
   ```
   
   ### Are these changes tested?
   
   Yes.
   
   ### Are there any user-facing changes?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to