alamb commented on code in PR #7576:
URL: https://github.com/apache/arrow-rs/pull/7576#discussion_r2118189910
##########
parquet/src/bin/parquet-rewrite.rs:
##########
@@ -252,6 +303,19 @@ fn main() {
if let Some(value) = args.compression {
writer_properties_builder =
writer_properties_builder.set_compression(value.into());
}
+ {
Review Comment:
I don't think this extra level of braces is necessary (there is nothing in
the scope that needs the change)
Perhaps we could remove the extra level of nesting?
##########
parquet/src/bin/parquet-rewrite.rs:
##########
@@ -168,10 +215,14 @@ struct Args {
#[clap(short, long)]
output: String,
- /// Compression used.
+ /// Compression used for any column.
#[clap(long, value_enum)]
compression: Option<CompressionArgs>,
+ /// Encoding used for any column, if dictionary is not enabled.
Review Comment:
```suggestion
/// Encoding used for all columns, if dictionary is not enabled.
```
##########
parquet/src/bin/parquet-rewrite.rs:
##########
@@ -168,10 +215,14 @@ struct Args {
#[clap(short, long)]
output: String,
- /// Compression used.
+ /// Compression used for any column.
Review Comment:
```suggestion
/// Compression used for all columns
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
