eitsupi commented on code in PR #46581: URL: https://github.com/apache/arrow/pull/46581#discussion_r2118678454
########## r/tools/lint.R: ########## Review Comment: I believe the `tools` directory is distributed as part of the source R package and is generally intended to be used to include files for use during source installation[^1][^2]. Since this script is used during development and is not needed during installation, probably it should be moved to a directory that is not included in the source R package (and is listed in `.Rbuildignore`). If I understand correctly, the same reason why files like `list.sh` are not included in the subdirectory for now. [^1]: _If your configure script needs auxiliary files, it is recommended that you ship them in a tools directory (as R itself does)._<https://cran.r-project.org/doc/manuals/r-release/R-exts.html#Configure-and-cleanup-1> [^2]: _tools/: auxiliary files needed during configuration, usually found in the company of a configure script._ <https://r-pkgs.org/misc.html#other-directories> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
