pitrou commented on code in PR #46620:
URL: https://github.com/apache/arrow/pull/46620#discussion_r2118839890


##########
docs/source/cpp/parquet.rst:
##########
@@ -450,38 +450,46 @@ Logical types
 Specific logical types can override the default Arrow type mapping for a given
 physical type.
 
-+-------------------+-----------------------------+----------------------------+---------+
-| Logical type      | Physical type               | Mapped Arrow type          
| Notes   |
-+===================+=============================+============================+=========+
-| NULL              | Any                         | Null                       
| \(1)    |
-+-------------------+-----------------------------+----------------------------+---------+
-| INT               | INT32                       | Int8 / UInt8 / Int16 /     
|         |
-|                   |                             | UInt16 / Int32 / UInt32    
|         |
-+-------------------+-----------------------------+----------------------------+---------+
-| INT               | INT64                       | Int64 / UInt64             
|         |
-+-------------------+-----------------------------+----------------------------+---------+
-| DECIMAL           | INT32 / INT64 / BYTE_ARRAY  | Decimal128 / Decimal256    
| \(2)    |
-|                   | / FIXED_LENGTH_BYTE_ARRAY   |                            
|         |
-+-------------------+-----------------------------+----------------------------+---------+
-| DATE              | INT32                       | Date32                     
| \(3)    |
-+-------------------+-----------------------------+----------------------------+---------+
-| TIME              | INT32                       | Time32 (milliseconds)      
|         |
-+-------------------+-----------------------------+----------------------------+---------+
-| TIME              | INT64                       | Time64 (micro- or          
|         |
-|                   |                             | nanoseconds)               
|         |
-+-------------------+-----------------------------+----------------------------+---------+
-| TIMESTAMP         | INT64                       | Timestamp (milli-, micro-  
|         |
-|                   |                             | or nanoseconds)            
|         |
-+-------------------+-----------------------------+----------------------------+---------+
-| STRING            | BYTE_ARRAY                  | String / LargeString /     
|         |
-|                   |                             | StringView                 
|         |
-+-------------------+-----------------------------+----------------------------+---------+
-| LIST              | Any                         | List                       
| \(4)    |
-+-------------------+-----------------------------+----------------------------+---------+
-| MAP               | Any                         | Map                        
| \(5)    |
-+-------------------+-----------------------------+----------------------------+---------+
-| FLOAT16           | FIXED_LENGTH_BYTE_ARRAY     | HalfFloat                  
|         |
-+-------------------+-----------------------------+----------------------------+---------+
++-------------------+-----------------------------+----------------------------+----------+
+| Logical type      | Physical type               | Mapped Arrow type          
| Notes    |
++===================+=============================+============================+==========+
+| NULL              | Any                         | Null                       
| \(1)     |
++-------------------+-----------------------------+----------------------------+----------+
+| INT               | INT32                       | Int8 / UInt8 / Int16 /     
|          |
+|                   |                             | UInt16 / Int32 / UInt32    
|          |
++-------------------+-----------------------------+----------------------------+----------+
+| INT               | INT64                       | Int64 / UInt64             
|          |
++-------------------+-----------------------------+----------------------------+----------+
+| DECIMAL           | INT32 / INT64 / BYTE_ARRAY  | Decimal128 / Decimal256    
| \(2)     |
+|                   | / FIXED_LENGTH_BYTE_ARRAY   |                            
|          |
++-------------------+-----------------------------+----------------------------+----------+
+| DATE              | INT32                       | Date32                     
| \(3)     |
++-------------------+-----------------------------+----------------------------+----------+
+| TIME              | INT32                       | Time32 (milliseconds)      
|          |
++-------------------+-----------------------------+----------------------------+----------+
+| TIME              | INT64                       | Time64 (micro- or          
|          |
+|                   |                             | nanoseconds)               
|          |
++-------------------+-----------------------------+----------------------------+----------+
+| TIMESTAMP         | INT64                       | Timestamp (milli-, micro-  
|          |
+|                   |                             | or nanoseconds)            
|          |
++-------------------+-----------------------------+----------------------------+----------+
+| STRING            | BYTE_ARRAY                  | String / LargeString /     
|          |
+|                   |                             | StringView                 
|          |
++-------------------+-----------------------------+----------------------------+----------+
+| LIST              | Any                         | List                       
| \(4)     |
++-------------------+-----------------------------+----------------------------+----------+
+| MAP               | Any                         | Map                        
| \(5)     |
++-------------------+-----------------------------+----------------------------+----------+
+| FLOAT16           | FIXED_LENGTH_BYTE_ARRAY     | HalfFloat                  
|          |
++-------------------+-----------------------------+----------------------------+----------+
+| UUID              | FIXED_LENGTH_BYTE_ARRAY     | Extension (arrow.uuid)     
| \(6)     |
++-------------------+-----------------------------+----------------------------+----------+
+| JSON              | BYTE_ARRAY                  | Extension (arrow.json)     
| \(6)     |
++-------------------+-----------------------------+----------------------------+----------+
+| GEOMETRY          | BYTE_ARRAY                  | Extension (geoarrow.wkb)   
| \(6) \(7)|
++-------------------+-----------------------------+----------------------------+----------+
+| GEOGRAPHY         | BYTE_ARRAY                  | Extension (geoarrow.wkb)   
| \(6) \(7)|

Review Comment:
   This will probably look better by using literal quotes (you'll need to 
reformat the table though).
   ```suggestion
   | UUID              | FIXED_LENGTH_BYTE_ARRAY     | Extension 
(``arrow.uuid``) | \(6)     |
   
+-------------------+-----------------------------+----------------------------+----------+
   | JSON              | BYTE_ARRAY                  | Extension 
(``arrow.json``) | \(6)     |
   
+-------------------+-----------------------------+----------------------------+----------+
   | GEOMETRY          | BYTE_ARRAY                  | Extension 
(``geoarrow.wkb``) | \(6) \(7)|
   
+-------------------+-----------------------------+----------------------------+----------+
   | GEOGRAPHY         | BYTE_ARRAY                  | Extension 
(``geoarrow.wkb``) | \(6) \(7)|
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to