kou commented on code in PR #46422:
URL: https://github.com/apache/arrow/pull/46422#discussion_r2120040701
##########
cpp/src/arrow/array/statistics_test.cc:
##########
@@ -96,6 +99,72 @@ TEST(ArrayStatisticsTest, TestEquality) {
ASSERT_NE(statistics1, statistics2);
statistics2.is_max_exact = true;
ASSERT_EQ(statistics1, statistics2);
+
+ // Test different index
+ statistics1.max = static_cast<uint64_t>(29);
+ ASSERT_NE(statistics1, statistics2);
Review Comment:
Ah, "different index" in the comment means that different type? If so, the
following is better.
```suggestion
statistics1.max = static_cast<int64_t>(29);
statistics2.max = static_cast<uint64_t>(29);
ASSERT_NE(statistics1, statistics2);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
