etseidl commented on code in PR #7585:
URL: https://github.com/apache/arrow-rs/pull/7585#discussion_r2121834528


##########
parquet/src/arrow/array_reader/byte_array_dictionary.rs:
##########
@@ -165,6 +165,13 @@ where
     }
 
     fn consume_batch(&mut self) -> Result<ArrayRef> {
+        if self.record_reader.num_values() == 0 {
+            // once the record_reader has been consumed, we've replaced its 
values with the default
+            // variant of DictionaryBuffer (Offset). If `consume_batch`` then 
gets called again, we

Review Comment:
   ```suggestion
               // variant of DictionaryBuffer (Offset). If `consume_batch` then 
gets called again, we
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to