zeroshade commented on code in PR #395:
URL: https://github.com/apache/arrow-go/pull/395#discussion_r2121926291
##########
parquet/variant/builder.go:
##########
@@ -777,6 +791,18 @@ func (b *Builder) FinishObject(start int, fields
[]FieldEntry) error {
return nil
}
+// AppendEncoded is a special case where we directly append a pre-encoded
variant
+// value. Its keys must already be in the dictionary and v must already be
+// a properly encoded variant value. No checking is performed here currently,
so
+// be careful as this can easily lead to an invalid variant result.
+func (b *Builder) AppendEncoded(v []byte) error {
Review Comment:
that's fair, I'll rename it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
