toddmeng-db commented on code in PR #2896:
URL: https://github.com/apache/arrow-adbc/pull/2896#discussion_r2122424817
##########
csharp/src/Drivers/Databricks/DatabricksConnection.cs:
##########
@@ -168,18 +168,14 @@ private void ValidateProperties()
Properties.TryGetValue(AdbcOptions.Connection.CurrentCatalog, out
defaultCatalog);
Properties.TryGetValue(AdbcOptions.Connection.CurrentDbSchema, out
defaultSchema);
- if (!string.IsNullOrWhiteSpace(defaultCatalog))
+ if (!string.IsNullOrWhiteSpace(defaultCatalog) ||
!string.IsNullOrWhiteSpace(defaultSchema))
{
_defaultNamespace = new TNamespace
{
CatalogName = defaultCatalog,
Review Comment:
I see that odbc allows for setting catalog to whitespace; but I also think
this will make the query broken:
Listing tables 'catalog : , schemaPattern : %, tableTypes : null,
tableName : %'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
