Re: [PR] feat: add `row_group_is_[max/min]_value_exact` to StatisticsConverter [arrow-rs]

[via GitHub]

etseidl commented on code in PR #7574:
URL: https://github.com/apache/arrow-rs/pull/7574#discussion_r2124093948


##########
parquet/tests/arrow_reader/mod.rs:
##########
@@ -987,6 +991,33 @@ fn create_data_batch(scenario: Scenario) -> 
Vec<RecordBatch> {
                 make_utf8_batch(vec![Some("e"), Some("f"), Some("g"), 
Some("h"), Some("i")]),
             ]
         }
+        Scenario::TruncatedUTF8 => {
+            // Make utf8 batch with strings longer than 64 bytes
+            // to check truncation of row group statistics
+            vec![
+                make_utf8_batch(vec![
+                    Some(&("a".repeat(64) + "1")),
+                    Some(&("b".repeat(64) + "2")),
+                    Some(&("c".repeat(64) + "3")),

Review Comment:
   Ahh, with sleep I now see the schema is set in `make_test_file_rg`...the 
first batch is used.
   
https://github.com/apache/arrow-rs/blob/0ae9f66d10141c8d5054fd77f73168c7a2ea2819/parquet/tests/arrow_reader/mod.rs#L1037-L1039
   Perhaps a note should be added that if nulls are desired, they need to be 
included in the first batch.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org