raulcd commented on code in PR #46261:
URL: https://github.com/apache/arrow/pull/46261#discussion_r2124368017
##########
r/src/compute.cpp:
##########
@@ -618,6 +622,13 @@ SEXP compute__CallFunction(std::string func_name,
cpp11::list args, cpp11::list
// [[arrow::export]]
std::vector<std::string> compute__GetFunctionNames() {
+#if ARROW_VERSION_MAJOR >= 21
+ auto compute_init_status_ = arrow::compute::Initialize();
+ if (!compute_init_status_.ok()) {
+ cpp11::stop("Failed to initialize compute functions: %s",
+ compute_init_status_.ToString().c_str());
+ }
Review Comment:
Thanks for pointing that out. I was not aware of it. I did see other usages
of `cpp11::stop` and didn't see `StopIfNotOk`, I've updated accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
