davidhcoe commented on code in PR #2917:
URL: https://github.com/apache/arrow-adbc/pull/2917#discussion_r2124400987


##########
go/adbc/driver/snowflake/connection.go:
##########
@@ -483,9 +484,17 @@ func (c *connectionImpl) toArrowField(columnInfo 
driverbase.ColumnInfo) arrow.Fi
        case "DATETIME":
                fallthrough
        case "TIMESTAMP", "TIMESTAMP_NTZ":
-               field.Type = &arrow.TimestampType{Unit: arrow.Nanosecond}
+               if c.useMaxMicrosecondTimestampPrecision {

Review Comment:
   hmm. This is a tricky one. At that point, we could have the option set for 
the database context, and therefore the connection context, and report that the 
item is in microseconds. However, if the statement option is set to not use 
microseconds, then the schema would have been reported incorrectly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to