alamb commented on code in PR #7602:
URL: https://github.com/apache/arrow-rs/pull/7602#discussion_r2126437508
##########
parquet-variant/src/variant.rs:
##########
@@ -327,6 +327,10 @@ impl<'m, 'v> VariantArray<'m, 'v> {
todo!()
}
+ pub fn is_empty(&self) -> bool {
Review Comment:
this is required by clippy
##########
parquet-variant/src/variant.rs:
##########
@@ -88,7 +88,7 @@ impl OffsetSizeBytes {
}
#[derive(Clone, Debug, Copy, PartialEq)]
-pub(crate) struct VariantMetadataHeader {
+pub struct VariantMetadataHeader {
Review Comment:
Since this in the public API, it needs to be pub as well
##########
parquet-variant/tests/variant_interop.rs:
##########
@@ -23,8 +23,8 @@
use std::fs;
use std::path::{Path, PathBuf};
-use crate::variant::{Variant, VariantMetadata};
use arrow_schema::ArrowError;
+use parquet_variant::{Variant, VariantMetadata};
Review Comment:
My actual goal with this PR was to re-enable this test as I have fixed
- https://github.com/apache/parquet-testing/issues/81
```
// TODO Reenable when
https://github.com/apache/parquet-testing/issues/81 is fixed
// ("primitive_null", Variant::Null),
```
However, when I did I still got an error as the value is empty -- I'll file
another ticket / fix in parquet-testing for that as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
