nealrichardson commented on a change in pull request #9927:
URL: https://github.com/apache/arrow/pull/9927#discussion_r608897792
##########
File path: r/R/dplyr.R
##########
@@ -619,9 +619,23 @@ collect.arrow_dplyr_query <- function(x, as_data_frame =
TRUE, ...) {
restore_dplyr_features(tab, x)
}
}
-collect.ArrowTabular <- as.data.frame.ArrowTabular
+collect.ArrowTabular <- function(x, as_data_frame = TRUE, ...) {
+ if (as_data_frame) as.data.frame(x, ...) else x
+}
collect.Dataset <- function(x, ...) dplyr::collect(arrow_dplyr_query(x), ...)
+compute.arrow_dplyr_query <- function(x, ...) dplyr::collect(x, as_data_frame
= FALSE)
+compute.ArrowTabular <- function(x, ...) x
+compute.Dataset <- function(x, ...) {
Review comment:
Not to scope creep, but now that we can project with renaming etc.
(`mutate()`), I think all `restore_dplyr_features()` needs to do is keep track
of `group_by_vars`. There might be a simpler way to handle that that solves
your concern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
