pitrou commented on code in PR #46715:
URL: https://github.com/apache/arrow/pull/46715#discussion_r2128238914
##########
cpp/src/arrow/compute/expression.cc:
##########
@@ -260,7 +260,9 @@ bool Expression::Equals(const Expression& other) const {
return false;
}
-bool Identical(const Expression& l, const Expression& r) { return l.impl_ ==
r.impl_; }
+ARROW_EXPORT bool Identical(const Expression& l, const Expression& r) {
Review Comment:
This could easily be a static method on `Expression` instead of a friend
function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
