alamb commented on code in PR #401:
URL:
https://github.com/apache/arrow-rs-object-store/pull/401#discussion_r2130551377
##########
src/gcp/builder.rs:
##########
@@ -674,7 +674,8 @@ mod tests {
let err = GoogleCloudStorageBuilder::new()
.with_service_account_path(service_account_path.to_str().unwrap())
.with_bucket_name("foo")
- .with_proxy_url("asdf://example.com")
+ // use invalid url
Review Comment:
Same as above
##########
src/client/retry.rs:
##########
@@ -622,7 +622,7 @@ mod tests {
assert_eq!(r.status(), StatusCode::OK);
// Handles redirect loop
- for _ in 0..10 {
+ for _ in 0..11 {
Review Comment:
I believe this change is needed due to
https://github.com/seanmonstar/reqwest/pull/2664
without this change the test fails because the redirect loop fails to
trigger the limit
##########
src/aws/builder.rs:
##########
@@ -1526,7 +1526,8 @@ mod tests {
.with_region("region")
.with_bucket_name("bucket_name")
.with_allow_http(true)
- .with_proxy_url("asdf://example.com")
+ // use invalid url
Review Comment:
I suspect, but don't know, that this change is required by
- https://github.com/seanmonstar/reqwest/pull/2681
the test expects the proxy config to fail, but after the reqwest upgrade it
was passing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
