lidavidm commented on code in PR #2922:
URL: https://github.com/apache/arrow-adbc/pull/2922#discussion_r2131509464
##########
python/adbc_driver_manager/adbc_driver_manager/_lib.pyx:
##########
@@ -420,6 +420,22 @@ cdef class ArrowArrayStreamHandle:
"""The address of the ArrowArrayStream."""
return <uintptr_t> &self.stream
+ @property
+ def is_valid(self) -> bool:
+ """Check validility (object has non-NULL release pointer)."""
+ return self.stream.release != NULL
+
+ def release(self):
+ """Release this stream without having to import it.
+
+ No-op if already released (if ``not self.is_valid``).
+
+ Postcondition: ``not self.is_valid``.
+ """
+ if self.stream.release != NULL:
+ self.stream.release(&self.stream)
+ self.stream.release = NULL
Review Comment:
Updated
##########
python/adbc_driver_manager/adbc_driver_manager/_lib.pyx:
##########
@@ -420,6 +420,22 @@ cdef class ArrowArrayStreamHandle:
"""The address of the ArrowArrayStream."""
return <uintptr_t> &self.stream
+ @property
+ def is_valid(self) -> bool:
+ """Check validility (object has non-NULL release pointer)."""
+ return self.stream.release != NULL
+
+ def release(self):
+ """Release this stream without having to import it.
+
+ No-op if already released (if ``not self.is_valid``).
+
+ Postcondition: ``not self.is_valid``.
+ """
+ if self.stream.release != NULL:
+ self.stream.release(&self.stream)
+ self.stream.release = NULL
Review Comment:
I also added the methods to ArrowArray/ArrowSchema even though they're not
used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
