hiroyuki-sato commented on code in PR #46727:
URL: https://github.com/apache/arrow/pull/46727#discussion_r2131627025
##########
ci/scripts/conan_build.sh:
##########
@@ -29,53 +29,53 @@ export ARROW_HOME=${source_dir}
conan_args=()
conan_args+=(--build=missing)
if [ -n "${ARROW_CONAN_PARQUET:-}" ]; then
- conan_args+=(--options arrow/*:parquet=${ARROW_CONAN_PARQUET})
- conan_args+=(--options arrow/*:with_thrift=${ARROW_CONAN_PARQUET})
- conan_args+=(--options arrow/*:with_boost=${ARROW_CONAN_PARQUET})
+ conan_args+=(--options arrow/*:parquet="${ARROW_CONAN_PARQUET}")
Review Comment:
I want to double check just in case.
Does the '*' character is just the character not a wildcard character ?
And suggested change means not only `parquet` but also `with_thrift and
`with_boost`?
```
conan_args+=(--options "arrow/*:parquet=${ARROW_CONAN_PARQUET}")
conan_args+=(--options "arrow/*:with_thrift=${ARROW_CONAN_PARQUET}")
conan_args+=(--options "arrow/*:with_boost=${ARROW_CONAN_PARQUET}")
```
and the rest of belows
```
if [ -n "${ARROW_CONAN_WITH_GLOG:-}" ]; then
conan_args+=(--options arrow/*:with_glog="${ARROW_CONAN_WITH_GLOG}")
fi
if [ -n "${ARROW_CONAN_WITH_JEMALLOC:-}" ]; then
conan_args+=(--options
arrow/*:with_jemalloc="${ARROW_CONAN_WITH_JEMALLOC}")
fi
if [ -n "${ARROW_CONAN_WITH_JSON:-}" ]; then
conan_args+=(--options arrow/*:with_json="${ARROW_CONAN_WITH_JSON}")
fi
if [ -n "${ARROW_CONAN_WITH_LZ4:-}" ]; then
conan_args+=(--options arrow/*:with_lz4="${ARROW_CONAN_WITH_LZ4}")
fi
if [ -n "${ARROW_CONAN_WITH_SNAPPY:-}" ]; then
conan_args+=(--options arrow/*:with_snappy="${ARROW_CONAN_WITH_SNAPPY}")
fi
if [ -n "${ARROW_CONAN_WITH_ZSTD:-}" ]; then
conan_args+=(--options arrow/*:with_zstd="${ARROW_CONAN_WITH_ZSTD}")
fi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
