EnricoMi commented on code in PR #45462:
URL: https://github.com/apache/arrow/pull/45462#discussion_r2131742482
##########
cpp/src/parquet/encryption/encryption.h:
##########
@@ -429,6 +429,16 @@ class PARQUET_EXPORT FileEncryptionProperties {
return encrypted_columns_;
}
+ /// All columns in encrypted_columns must refer to columns in the given
schema.
Review Comment:
Rephrased entirely
```
/// \brief Check and replace encrypted columns according to schema
///
/// Checks all columns in encrypted_columns reference columns in the given
schema.
/// Replaces parent fields in encrypted_columns with all their nested
fields,
/// all using the same encrypion key.
/// Fields referenced by schema paths are replaced with the respective
parquet paths.
/// These are usually identical, except for nested fields of lists and
maps.
```
##########
cpp/src/parquet/encryption/encryption.h:
##########
@@ -429,6 +429,16 @@ class PARQUET_EXPORT FileEncryptionProperties {
return encrypted_columns_;
}
+ /// All columns in encrypted_columns must refer to columns in the given
schema.
+ /// They can also refer to parent fields if schema contains nested fields.
Then
+ /// all those nested fields of a matching parent field are encrypted by the
same key.
+ /// This method modifies encrypted_columns to reflect this.
+ ///
+ /// Columns in encrypted_columns can refer to the parquet column paths as
well as the
+ /// schema paths of columns. Those are usually identical, except for nested
fields of
+ /// lists and maps.
+ void encrypt_schema(const SchemaDescriptor& schema);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
