alamb commented on PR #7614: URL: https://github.com/apache/arrow-rs/pull/7614#issuecomment-2950030877
I also ran this PR with a new concat benchmark in - https://github.com/apache/arrow-rs/pull/7617 And it also shows pretty sweet gains ``` group coalesce_improvements main ----- --------------------- ---- concat utf8_view max_str_len=128 null_density=0 1.00 80.3±0.52µs ? ?/sec 1.12 89.6±0.27µs ? ?/sec concat utf8_view max_str_len=128 null_density=0.2 1.00 86.1±0.48µs ? ?/sec 1.73 148.9±0.75µs ? ?/sec concat utf8_view max_str_len=20 null_density=0 1.00 79.9±0.34µs ? ?/sec 1.24 99.2±0.23µs ? ?/sec concat utf8_view max_str_len=20 null_density=0.2 1.00 98.4±0.30µs ? ?/sec 1.48 145.5±0.52µs ? ?/sec concat utf8_view all_inline max_str_len=12 null_density=0 1.00 40.2±3.69µs ? ?/sec 1.80 72.4±0.71µs ? ?/sec concat utf8_view all_inline max_str_len=12 null_density=0.2 1.00 52.0±2.95µs ? ?/sec 1.73 90.0±0.98µs ? ?/sec ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
