alamb commented on code in PR #7619:
URL: https://github.com/apache/arrow-rs/pull/7619#discussion_r2132715898
##########
arrow/benches/coalesce_kernels.rs:
##########
@@ -77,17 +77,33 @@ fn add_all_filter_benchmarks(c: &mut Criterion) {
num_output_batches: 50,
null_density,
selectivity,
+ max_string_len: 30,
schema: &single_schema,
}
.build();
+ // Model mostly short strings, but some longer ones
Review Comment:
Previously all the benchmarks used a max size of 30. Now I have 20 (12/20 =
60% will be inlined views) and 128 where only 12/128 ~ 1% will be inlined views.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
