sumansuhag commented on issue #34861: URL: https://github.com/apache/arrow/issues/34861#issuecomment-2951798055
Hi! Thanks for the detailed bug report, austin3dickey. The issue with the cpp-micro benchmarks failing due to the GTest C++ standard mismatch is exactly what the new CMake check was meant to address, but it looks like it revealed a build system issue after PR #34765. The main concern here is about how we manage C++ standard compliance and external dependencies in our CMake projects. While the quick fix mentioned in the error message (-DGTest_SOURCE='BUNDLED') should take care of the problem for now, we need to think about our long-term plan for dealing with GTest and similar dependencies. Here are a few options to consider so that we don’t run into this kind of problem again: 1. **Default to Bundled GTest**: Set -DGTest_SOURCE=BUNDLED as the default for CI/CD and local setups to make sure we're all using the same version and C++ standard for benchmarking. This would give us a stable environment. 2. **Conditional Checks in CMake**: Update ThirdpartyToolchain.cmake to check the CXX_STANDARD of the system-provided GTest when setting things up. If it's below C++17, we can switch to the bundled version automatically or show a clearer error message to guide the user. This approach adds some flexibility but could also complicate things a bit. 3. **Documentation/Checks for Environment**: Clearly outline the required C++ standard for the system GTest if we choose not to use the bundled version and maybe add checks before building. Since PR #34765 added this check, it shows we're aiming for C++17 compliance. @HaochengLIU, what's your go-to plan for managing the GTest dependency and keeping the cpp-micro benchmarks running smoothly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
