alamb commented on code in PR #7623:
URL: https://github.com/apache/arrow-rs/pull/7623#discussion_r2133748478
##########
arrow-array/src/builder/generic_bytes_view_builder.rs:
##########
@@ -201,43 +201,10 @@ impl<T: ByteViewType + ?Sized> GenericByteViewBuilder<T> {
let b = b.get_unchecked(start..end);
let view = make_view(b, block, offset);
- self.views_buffer.push(view);
+ self.views_builder.append(view);
self.null_buffer_builder.append_non_null();
}
- /// Appends an array to the builder.
- /// This will flush any in-progress block and append the data buffers
- /// and add the (adapted) views.
- pub fn append_array(&mut self, array: &GenericByteViewArray<T>) {
- self.flush_in_progress();
- // keep original views if this array is the first to be added or if
there are no data buffers (all inline views)
- let keep_views = self.completed.is_empty() ||
array.data_buffers().is_empty();
-
- self.completed.extend(array.data_buffers().iter().cloned());
-
- if keep_views {
- self.views_buffer.extend_from_slice(array.views());
- } else {
- let starting_buffer = self.completed.len() as u32;
Review Comment:
I think one bug is that this starting buffer value should be calculated
before extending `self.completed` a few lines above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
