hiroyuki-sato commented on PR #46737:
URL: https://github.com/apache/arrow/pull/46737#issuecomment-2954790597

   > Ah, conan-io/conan-docker-tools doesn't provide images that are based on 
newer Ubuntu yet?
   
   Yes. (Ubuntu 16.04 is the latest).
   https://hub.docker.com/u/conanio
   
   > BTW, why is RapidJSON provided by Ubuntu related? Conan has RapidJSON 
1.1.0: 
https://github.com/conan-io/conan-center-index/blob/master/recipes/rapidjson/config.yml
   
   Before creating this PR. the status was the below.
   
   | group          | status | RapidJSON     |
   |----------------|--------|---------------|
   | conan-maximum: | passed |  Build 1.1.0  |
   | conan-minimum: | failed |  Not build    |
   
   conan-maximum built RapidJSON from source code. So, conan-maximum build 
passed.
   `conan-maximum` build wihth `ARROW_CONAN_WITH_JSON=ON`, It set 
`arrow/*with-json=true` in the `conan` command)
   
   However, `conam-minumum` doesn't set `ARROW_CONAN_WITH_JSON` option. All of 
settings use default.
   https://github.com/apache/arrow/issues/46736#issuecomment-2951546997
   As a reusult, It try to use the RapidJSON provided by Ubuntu. But It use 
`RapidJSON 0.12`.
   
https://github.com/apache/arrow/blob/0e5249b0e8f060f8ee5136579bfeed8c92d0d1ab/ci/conan/all/conanfile.py#L374
   I think that this is the reson of build failure.
   
   IIUC, both(`conon-maximum` and `conan-minimum` ) must be build RapidJSON 
from source. 
   
   Changing `tc.variables["RapidJSON_SOURCE"] = "SYSTEM"` to 
`tc.variables["RapidJSON_SOURCE"] = "AUTO"` solve
   `conan-minimum` issue. I think `AUTO` means build from source if needed.
   But you told me it's not proper way.
   
   I don't know how to fix yet. It seems I need fix upstream side.
   
   > How did you do? We have a script for it: 
https://github.com/apache/arrow/blob/main/ci/conan/merge_upstream.sh
   
   I'll try this.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to