shu-kitamura commented on PR #46732: URL: https://github.com/apache/arrow/pull/46732#issuecomment-2955425422
Thank you for reviewing it so many times. > What I meant earlier is that the test case using `arr[::-1]` is already effectively covered in `test_array_slice_negative_step()` via `slice(None, None, -1)`, so there's no need to add an additional test as I originally suggested — sorry for that. Sorry too. I misunderstood. I removed `test_slicing_with_non_trivial_step()`. > We can add a comment in this specific slice case (`# GH-46606`) as it is done [here](https://github.com/apache/arrow/blob/0e5249b0e8f060f8ee5136579bfeed8c92d0d1ab/python/pyarrow/tests/test_array.py#L507-L508). I added the comment `# GH-46606` to the line `slice(None, None, -1)`. > With the change introduced in this PR, `test_array_slice_negative_step()` should now pass without requiring NumPy, which means the [NumPy mark](https://github.com/apache/arrow/blob/0e5249b0e8f060f8ee5136579bfeed8c92d0d1ab/python/pyarrow/tests/test_array.py#L491) can (and should) be removed. I remove `@pytest.mark.numpy` from `test_array_slice_negative_step()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
