benibus commented on code in PR #45998: URL: https://github.com/apache/arrow/pull/45998#discussion_r2136802611
########## cpp/src/arrow/filesystem/hdfs.h: ########## @@ -22,18 +22,32 @@ #include <vector> #include "arrow/filesystem/filesystem.h" -#include "arrow/io/hdfs.h" #include "arrow/util/uri.h" +namespace arrow::io::internal { +class HdfsReadableFile; +class HdfsOutputStream; + +struct HdfsPathInfo; +} // namespace arrow::io::internal Review Comment: Here as well. ########## cpp/src/arrow/filesystem/hdfs_internal.h: ########## @@ -33,8 +38,13 @@ namespace arrow { class Status; +using internal::IOErrorFromErrno; + namespace io::internal { +class HdfsReadableFile; +class HdfsOutputStream; + Review Comment: Why are we using the `io::internal` namespace here instead of `fs::internal`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org