raulcd commented on PR #46732:
URL: https://github.com/apache/arrow/pull/46732#issuecomment-2959404534
Thanks @pitrou for taking a look, I should have pinged you on this one
before merging.
> Were any benchmarks run on this change?
I haven't run benchmarks, maybe we should validate the performance changes
and if significant use numpy if available otherwise use the new code path?
> Calling `list(range(...))` and converting it to a Arrow array afterwards
is going to be significantly more costly (and memory-consuming) than
`np.arange`.
when you say converting it to a Arrow array afterwards you mean on the case
of no indices being returned?
```
if len(indices) == 0:
return arrow_obj.slice(0, 0)
```
or when using the `indices` list on `take`? this would still have to convert
from the Numpy array to an Arrow array on the previous case, right?
Is Pylist to Arrow array that much slow than from Numpy array to Arrow array?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
