WillAyd commented on PR #774: URL: https://github.com/apache/arrow-nanoarrow/pull/774#issuecomment-2959928953
That's related to these warnings right? ``` 2025-06-10T16:20:24.6071874Z [38/119] Compiling C++ object nanoarrow_c_data_integration.dll.p/src_nanoarrow_integration_c_data_integration.cc.obj 2025-06-10T16:20:24.6247457Z ..\src\nanoarrow/nanoarrow_testing.hpp(196): warning C4251: 'nanoarrow::testing::TestingJSONComparison::Difference::path': 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' needs to have dll-interface to be used by clients of 'nanoarrow::testing::TestingJSONComparison::Difference' 2025-06-10T16:20:24.6284547Z C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.43.34808\include\xstring(522): note: see declaration of 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' 2025-06-10T16:20:24.6754883Z ..\src\nanoarrow/nanoarrow_testing.hpp(197): warning C4251: 'nanoarrow::testing::TestingJSONComparison::Difference::actual': 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' needs to have dll-interface to be used by clients of 'nanoarrow::testing::TestingJSONComparison::Difference' 2025-06-10T16:20:24.6998862Z C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.43.34808\include\xstring(522): note: see declaration of 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' 2025-06-10T16:20:24.7292270Z ..\src\nanoarrow/nanoarrow_testing.hpp(198): warning C4251: 'nanoarrow::testing::TestingJSONComparison::Difference::expected': 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' needs to have dll-interface to be used by clients of 'nanoarrow::testing::TestingJSONComparison::Difference' 2025-06-10T16:20:24.7352268Z C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.43.34808\include\xstring(522): note: see declaration of 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' 2025-06-10T16:20:24.8419651Z ..\src\nanoarrow/nanoarrow_testing.hpp(270): warning C4251: 'nanoarrow::testing::TestingJSONComparison::differences_': 'std::vector<nanoarrow::testing::TestingJSONComparison::Difference,std::allocator<nanoarrow::testing::TestingJSONComparison::Difference>>' needs to have dll-interface to be used by clients of 'nanoarrow::testing::TestingJSONComparison' 2025-06-10T16:20:25.0622057Z C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.43.34808\include\vector(429): note: see declaration of 'std::vector<nanoarrow::testing::TestingJSONComparison::Difference,std::allocator<nanoarrow::testing::TestingJSONComparison::Difference>>' 2025-06-10T16:20:25.1453495Z [39/119] Compiling C++ object utils-test.exe.p/subprojects_googletest-1.14.0_googletest_src_gtest_main.cc.obj 2025-06-10T16:20:30.4698168Z [40/119] Compiling C++ object utils-test.exe.p/src_nanoarrow_common_utils_test.cc.obj 2025-06-10T16:20:31.1150121Z [41/119] Compiling C++ object utils-test.exe.p/subprojects_googletest-1.14.0_googlemock_src_gmock-all.cc.obj 2025-06-10T16:20:33.0328859Z [42/119] Compiling C++ object buffer-test.exe.p/src_nanoarrow_common_buffer_test.cc.obj 2025-06-10T16:20:38.8431711Z [43/119] Compiling C++ object buffer-test.exe.p/subprojects_googletest-1.14.0_googletest_src_gtest_main.cc.obj 2025-06-10T16:20:40.1982943Z [44/119] Compiling C++ object nanoarrow_testing.dll.p/src_nanoarrow_testing_testing.cc.obj 2025-06-10T16:20:40.5893311Z ..\src\nanoarrow/nanoarrow_testing.hpp(196): warning C4251: 'nanoarrow::testing::TestingJSONComparison::Difference::path': 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' needs to have dll-interface to be used by clients of 'nanoarrow::testing::TestingJSONComparison::Difference' 2025-06-10T16:20:40.9955906Z C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.43.34808\include\xstring(522): note: see declaration of 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' 2025-06-10T16:20:41.4963451Z ..\src\nanoarrow/nanoarrow_testing.hpp(197): warning C4251: 'nanoarrow::testing::TestingJSONComparison::Difference::actual': 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' needs to have dll-interface to be used by clients of 'nanoarrow::testing::TestingJSONComparison::Difference' 2025-06-10T16:20:41.8847405Z C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.43.34808\include\xstring(522): note: see declaration of 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' 2025-06-10T16:20:42.2870455Z ..\src\nanoarrow/nanoarrow_testing.hpp(198): warning C4251: 'nanoarrow::testing::TestingJSONComparison::Difference::expected': 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' needs to have dll-interface to be used by clients of 'nanoarrow::testing::TestingJSONComparison::Difference' 2025-06-10T16:20:42.4471786Z C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.43.34808\include\xstring(522): note: see declaration of 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' 2025-06-10T16:20:42.5958839Z ..\src\nanoarrow/nanoarrow_testing.hpp(270): warning C4251: 'nanoarrow::testing::TestingJSONComparison::differences_': 'std::vector<nanoarrow::testing::TestingJSONComparison::Difference,std::allocator<nanoarrow::testing::TestingJSONComparison::Difference>>' needs to have dll-interface to be used by clients of 'nanoarrow::testing::TestingJSONComparison' 2025-06-10T16:20:42.9118497Z C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.43.34808\include\vector(429): note: see declaration of 'std::vector<nanoarrow::testing::TestingJSONComparison::Difference,std::allocator<nanoarrow::testing::TestingJSONComparison::Difference>>' ``` Is that related to std::string or the TestingJSONComparison class itself? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
