WillAyd commented on PR #776: URL: https://github.com/apache/arrow-nanoarrow/pull/776#issuecomment-2962559614
Hmm I still think something is wrong here. CI shows an error, although the job itself doesn't fail (?) From reading up on it some more, I think the problem is that our nanoarrow testing dependency links libraries against both libnanoarrow and libnanoarrow_testing. The former can be shared while the latter is now forced to be static. The problem with the former being shared is that it would then require `NANOARROW_BUILD_DLL` to be defined, but the latter cannot have this defined (or else the symbols in a target are generated with dllimport). Maybe for now the best solution is to just force static libraries across the board on Windows? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
