alamb commented on issue #7641: URL: https://github.com/apache/arrow-rs/issues/7641#issuecomment-2963000973
> FWIW the point of that Miri behavior is to find code that incorrectly relies on `powf` and other functions giving precise results, despite the fact that the docs say: > > > The precision of this function is non-deterministic. This means it varies by platform, Rust version, and can even differ within the same execution from one invocation to the next. Thank you @RalfJung -- this makes sense. I think in the [test](https://github.com/apache/arrow-rs/blob/2be261b78b16a4aa7b5b9aece648bec663c0dbf1/arrow-array/src/arithmetic.rs#L791) that is failing is not trying to verify that we have a numerically stable `pow` implementation, but instead is trying to verify basic functionality The reason the test is failing is a classic issue of "a test is comparing floating point values using (bitwise) equality when they should be compared using a allowable epsilon" We were just "lucky" before that it didn't cause issues. So TLDR I think this is just a test thing and we should update the test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
