sgrebnov commented on code in PR #2961:
URL: https://github.com/apache/arrow-adbc/pull/2961#discussion_r2141228445
##########
csharp/test/Drivers/Interop/FlightSql/ClientTests.cs:
##########
@@ -159,12 +159,12 @@ public void CanClientExecuteQueryWithNoResults()
{
foreach (FlightSqlTestEnvironment environment in _environments)
{
- environment.Query = "SELECT * WHERE 0=1";
+ environment.Query = "SELECT 1 WHERE false"; // The query
simulates no results
environment.ExpectedResultsCount = 0;
using (Adbc.Client.AdbcConnection adbcConnection =
GetFlightSqlAdbcConnectionUsingConnectionString(environment,
_testConfiguration))
{
- Tests.ClientTests.CanClientExecuteQuery(adbcConnection,
environment, additionalCommandOptionsSetter: null, environment.Name);
+ Tests.ClientTests.CanClientExecuteQuery(adbcConnection,
environment, additionalCommandOptionsSetter: null, environmentName:
environment.Name);
Review Comment:
unrelated to SpiceAI: environment.Name was passing as query override
parameter previously
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
