alamb commented on code in PR #7652:
URL: https://github.com/apache/arrow-rs/pull/7652#discussion_r2143586985
##########
arrow/benches/coalesce_kernels.rs:
##########
@@ -214,10 +214,9 @@ fn filter_streams(
while num_output_batches > 0 {
let filter = filter_stream.next_filter();
let batch = data_stream.next_batch();
- // Apply the filter to the input batch
- let filtered_batch = arrow_select::filter::filter_record_batch(batch,
filter).unwrap();
- // Add the filtered batch to the coalescer
- coalescer.push_batch(filtered_batch).unwrap();
+ coalescer
+ .push_batch_with_filter(batch.clone(), filter)
Review Comment:
this is the point of the PR -- to add this API to prepare for the coalescer
to build it up incrementally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
