thisisnic commented on PR #46799: URL: https://github.com/apache/arrow/pull/46799#issuecomment-2969249846
> I am -0.5 on this. With pre-commit being a normal python package that can be easily installed I don't think we should limit ourselves to OS provided versions. I'm neutral on **what** approach we take but we absolutely should make sure we're not introducing additional friction for developers. If we choose not to support the older version, we should at least be *very* explicit about installation method in our docs then - i.e. that you must install the package using pip not apt. The error message from pre-commit in the case of an older version doesn't make it obvious why it's not working. Took a good chunk frustration (until dumping the error into an LLM worked) to solve it when I ran into this. > Though in this case I doubt there are many differences between the two versions? If some other hook needs a newer version we can always reconsider. The `pre-commit` command itself seems to not be part of earlier versions (see my error message on linked ticket). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
