thisisnic commented on code in PR #46675:
URL: https://github.com/apache/arrow/pull/46675#discussion_r2145139872
##########
cpp/src/arrow/array/array_test.cc:
##########
@@ -815,6 +815,23 @@ TEST_F(TestArray, TestMakeArrayFromMapScalar) {
AssertAppendScalar(pool_, std::make_shared<MapScalar>(scalar));
}
+TEST_F(TestArray, TestMakeArrayFromScalar_SmallintExtensionType) {
+ auto ext_type = std::make_shared<SmallintType>();
+ auto storage_scalar = std::make_shared<Int16Scalar>(42);
+ auto ext_scalar = std::make_shared<ExtensionScalar>(ext_type,
storage_scalar);
Review Comment:
```suggestion
auto ext_scalar = std::make_shared<ExtensionScalar>(storage_scalar,
ext_type);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
