IndifferentArea commented on PR #46730: URL: https://github.com/apache/arrow/pull/46730#issuecomment-2972782119
To implement interface aligned with what arrow-rs did, i have to change some behavior of `StringHeapBuild::FinishLastBlock()` and mark it as public. More specific, `FinishLastBlock()` just resize the last block before. Now `FinishLastBlock()` reset internal states, including `current_offset_`, `current_out_buffer_` and `current_remaining_bytes_`. I believe it's more safe and reasonable. The interface was private before so don't mind external usage, for current internal usage of `FinishLastBlock()`, they always reset or change all these status. If this change is unacceptable, plz let me know, i'll try to find another way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
