kou commented on code in PR #45306: URL: https://github.com/apache/arrow/pull/45306#discussion_r2149288859
########## cpp/cmake_modules/ThirdpartyToolchain.cmake: ########## @@ -1016,17 +1016,24 @@ set(FC_DECLARE_COMMON_OPTIONS) if(CMAKE_VERSION VERSION_GREATER_EQUAL 3.28) list(APPEND FC_DECLARE_COMMON_OPTIONS EXCLUDE_FROM_ALL TRUE) endif() +if(CMAKE_VERSION VERSION_GREATER_EQUAL 3.25) Review Comment: Good catch! I'll remove this check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
