kylebarron commented on code in PR #376:
URL:
https://github.com/apache/arrow-rs-object-store/pull/376#discussion_r2150352892
##########
src/azure/client.rs:
##########
@@ -1058,6 +1063,12 @@ fn to_list_result(value: ListResultInternal, prefix:
Option<&str>) -> Result<Lis
!matches!(blob.properties.resource_type.as_ref(), Some(typ) if typ
== "directory")
&& blob.name.len() > prefix.len()
})
+ .map(BlobInternal::try_from)
+ .filter_map(|parsed| match parsed {
+ Ok(parsed) => Some(parsed),
+ Err(_) if ignore_unparsable_paths => None,
+ Err(e) => panic!("cannot parse path: {e}"),
Review Comment:
In
https://github.com/apache/arrow-rs-object-store/pull/376#issuecomment-2927448265
@ttomasz said returning an error might require a breaking change, though now
that we've released 0.12.2 we can now merge breaking changes, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
