jpedroantunes commented on a change in pull request #9906:
URL: https://github.com/apache/arrow/pull/9906#discussion_r609689429



##########
File path: cpp/src/gandiva/function_registry_string.cc
##########
@@ -100,6 +100,9 @@ std::vector<NativeFunction> GetStringFunctionRegistry() {
                      kResultNullIfNull, "gdv_fn_like_utf8_utf8",
                      NativeFunction::kNeedsFunctionHolder),
 
+      NativeFunction("is_date", {}, DataTypeVector{utf8()}, boolean(), 
kResultNullIfNull,

Review comment:
       @projjal are you sure? Normally, the ISDATE function does not receive a 
pattern as input. Please, can you confirm it?
   
https://docs.oracle.com/cd/B28359_01/olap.111/b28126/dml_functions_1106.htm#OLADM567
   https://docs.dremio.com/sql-reference/sql-functions/datetime-functions.html
   https://docs.snowflake.com/en/sql-reference/functions/is_date-value.html




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to