crepererum commented on code in PR #405:
URL:
https://github.com/apache/arrow-rs-object-store/pull/405#discussion_r2152534120
##########
src/lib.rs:
##########
@@ -901,6 +894,30 @@ macro_rules! as_ref_impl {
as_ref_impl!(Arc<dyn ObjectStore>);
as_ref_impl!(Box<dyn ObjectStore>);
+/// Extension trait for [`ObjectStore`] with convinience functions.
Review Comment:
I've added a motivation text to both traits and also changed the
implementation to `async_trait`. Does this look more useful to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
