mbutrovich commented on code in PR #7687:
URL: https://github.com/apache/arrow-rs/pull/7687#discussion_r2152650029
##########
parquet/src/data_type.rs:
##########
@@ -33,7 +33,7 @@ use crate::util::bit_util::FromBytes;
/// Rust representation for logical type INT96, value is backed by an array of
`u32`.
/// The type only takes 12 bytes, without extra padding.
-#[derive(Clone, Copy, Debug, PartialOrd, Default, PartialEq, Eq)]
+#[derive(Clone, Copy, Debug, Default, PartialEq, Eq)]
pub struct Int96 {
value: [u32; 3],
Review Comment:
Doesn't this change the alignment of Int96 from 4 bytes to 8 bytes? What are
the broader implications of that, particularly in an array/vector of Int96?
Won't there be 4 bytes of padding?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
