alamb commented on issue #7683:
URL: https://github.com/apache/arrow-rs/issues/7683#issuecomment-2981027853

   > > The way StringView implemented this was to reuse the builder
   > 
   > I don't think we want to do that here, as the builders are typed on the 
keys and values and so this would result in a massive amount of code 
generation. The kernels in arrow-select by comparison use a number of tricks to 
avoid this.
   
   I don't understand the codegen concern  -- 
   
   I am imagining that only the `DictionaryArray` Types that were actually 
instantiated (aka that you called `gc` on) would get code generated for them as 
this would be a method on `DictionaryArray` 
   
   Most of the kernels in `arrow-select` take an `ArrayRef`/ `Datum`  that then 
gets typecast down and dispatched to a bunch of pre-compiled methods (which 
really does generate code bloat even if you don't use those types)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to