nealrichardson commented on a change in pull request #9589:
URL: https://github.com/apache/arrow/pull/9589#discussion_r609824485
##########
File path: r/R/dataset-scan.R
##########
@@ -56,7 +56,11 @@
Scanner <- R6Class("Scanner", inherit = ArrowObject,
public = list(
ToTable = function() dataset___Scanner__ToTable(self),
- Scan = function() dataset___Scanner__Scan(self)
+ ScanBatches = function() dataset___Scanner__ScanBatches(self),
+ Scan = function() {
+ .Deprecated("ScanBatches")
Review comment:
This is nice but probably not necessary, this was a (de facto) internal
method. If it were me I'd just delete it, but since you've already done this,
might as well keep it. Can you please just make a JIRA to delete this so we
don't forget to clean this up after the release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
