alamb commented on PR #7707:
URL: https://github.com/apache/arrow-rs/pull/7707#issuecomment-2984327357
Using this updated benchmark
Running this command:
```
cargo bench --bench coalesce_kernels -- "mixed_utf8view
\(max_string_len=128\), 8192, nulls: 0.1, selectivity: 0.8"
```
Results in these meaurements on main and branch
```
Benchmarking filter: mixed_utf8view (max_string_len=128), 8192, nulls: 0.1,
selectivity: 0.8: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase
target time to 9.9s, enable flat sampling, or reduce sample count to 40.
filter: mixed_utf8view (max_string_len=128), 8192, nulls: 0.1, selectivity:
0.8
time: [1.9285 ms 1.9592 ms 1.9921 ms]
change: [−29.038% −28.009% −26.891%] (p = 0.00 <
0.05)
Performance has improved.
time: [1.8064 ms 1.8350 ms 1.8648 ms]
time: [1.9849 ms 2.0140 ms 2.0429 ms]
time: [1.9166 ms 1.9308 ms 1.9466 ms]
```
On the branch
```
time: [2.5685 ms 2.5797 ms 2.5912 ms]
time: [2.6001 ms 2.6277 ms 2.6642 ms]
time: [2.5834 ms 2.6086 ms 2.6374 ms]
```
So something else is still going on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
