scovich commented on code in PR #7661:
URL: https://github.com/apache/arrow-rs/pull/7661#discussion_r2146996045
##########
parquet-variant/src/variant.rs:
##########
@@ -134,8 +136,10 @@ impl VariantMetadataHeader {
}
}
+/// [`Variant`] Metadata
+///
+/// see the Variant spec file for more information
Review Comment:
Should we link to the spec?
https://github.com/apache/parquet-format/blob/master/VariantEncoding.md#metadata-encoding
##########
parquet-variant/src/variant.rs:
##########
@@ -665,33 +669,133 @@ impl<'m, 'v> VariantList<'m, 'v> {
}
}
-/// Variant value. May contain references to metadata and value
+/// Represents a Parquet Variant
+///
+/// The lifetimes `'m` and `'v` are for metadata and value, respectively.
Review Comment:
nit?
```suggestion
/// The lifetimes `'m` and `'v` are for metadata and value buffers,
respectively.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
