kou commented on code in PR #46850:
URL: https://github.com/apache/arrow/pull/46850#discussion_r2155563932
##########
ruby/red-arrow/test/raw-records/test-dense-union-array.rb:
##########
@@ -35,45 +35,8 @@ def build_schema(type, type_codes)
}
end
- # TODO: Use Arrow::RecordBatch.new(build_schema(type, type_codes), records)
def build_record_batch(type, records)
- type_codes = [0, 1]
- schema = Arrow::Schema.new(build_schema(type, type_codes))
- type_ids = []
- offsets = []
- arrays = schema.fields[0].data_type.fields.collect do |field|
- sub_schema = Arrow::Schema.new([field])
- sub_records = []
- records.each do |record|
- column = record[0]
- next if column.nil?
- next unless column.key?(field.name)
- sub_records << [column[field.name]]
- end
- sub_record_batch = Arrow::RecordBatch.new(sub_schema,
- sub_records)
- sub_record_batch.columns[0].data
- end
- records.each do |record|
- column = record[0]
- if column.key?("0")
- type_id = type_codes[0]
- type_ids << type_id
- offsets << (type_ids.count(type_id) - 1)
- elsif column.key?("1")
- type_id = type_codes[1]
- type_ids << type_id
- offsets << (type_ids.count(type_id) - 1)
- end
- end
- union_array = Arrow::DenseUnionArray.new(schema.fields[0].data_type,
- Arrow::Int8Array.new(type_ids),
- Arrow::Int32Array.new(offsets),
- arrays)
- schema = Arrow::Schema.new(column: union_array.value_data_type)
- Arrow::RecordBatch.new(schema,
- records.size,
- [union_array])
+ Arrow::RecordBatch.new(build_schema(type, [0, 1]), records)
Review Comment:
```suggestion
type_codes = [0, 1]
Arrow::RecordBatch.new(build_schema(type, type_codes), records)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
