lidavidm commented on code in PR #2996:
URL: https://github.com/apache/arrow-adbc/pull/2996#discussion_r2155703966
##########
.github/workflows/rust.yml:
##########
@@ -143,3 +143,14 @@ jobs:
pushd rust
cargo doc --workspace --all-features
popd
+ - name: Verify MSRV (Minimum Supported Rust Version)
+ if: matrix.os == 'ubuntu-latest'
+ working-directory: rust
+ run: |
+ curl -L
"https://github.com/foresterre/cargo-msrv/releases/download/v0.18.4/cargo-msrv-x86_64-unknown-linux-gnu-v0.18.4.tgz";
|
Review Comment:
(1) Could we perhaps validate the SHA so that upstream can't change it
unexpectedly?
(2) Does it make sense to use `cargo install` instead (with a specific
commit), or a specific version of their Docker image? (With Docker, we could
even set this up so that it's run by docker-compose)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
