dinse commented on code in PR #46829:
URL: https://github.com/apache/arrow/pull/46829#discussion_r2155722411
##########
cpp/src/arrow/compute/kernels/scalar_validity_test.cc:
##########
@@ -106,6 +107,12 @@ TEST(TestValidityKernels, IsFinite) {
CheckScalar("is_finite",
{ArrayFromJSON(duration(TimeUnit::SECOND), "[0, 1, 42, null]")},
ArrayFromJSON(boolean(), "[true, true, true, null]"));
+ CheckScalar("is_finite", {ArrayFromJSON(float32(), "[1.0, NaN, Inf, null]")},
Review Comment:
Right, didn't notice that test. Fixed (had to update IsNullExec to work w/
float16 and nan_is_null).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
