WillAyd commented on code in PR #46839:
URL: https://github.com/apache/arrow/pull/46839#discussion_r2156030448
##########
cpp/src/arrow/compute/CMakeLists.txt:
##########
@@ -48,9 +48,16 @@ if(ARROW_TESTING AND ARROW_COMPUTE)
add_library(arrow_compute_testing OBJECT ${ARROW_COMPUTE_TESTING_SRCS})
# Even though this is still just an object library we still need to "link"
# arrow_compute_core_testing so that is also included correctly
- target_link_libraries(arrow_compute_testing
- PUBLIC $<TARGET_OBJECTS:arrow_compute_core_testing>
- PUBLIC ${ARROW_GTEST_GTEST_MAIN})
+ if(MSVC AND MSVC_VERSION LESS 1930) # gtest linkage needs compat on Visual
Studio 2019
Review Comment:
It appears so. Here is the last build log URL before I added this:
https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/52249396
So the failure messages looked like:
```
[----------] 18 tests from TestPivotKernel
[ RUN ] TestPivotKernel.Basics
unknown file: error: SEH exception with code 0xc0000005 thrown in the test
body.
Stack trace:
[ FAILED ] TestPivotKernel.Basics (2 ms)
[ RUN ] TestPivotKernel.BinaryKeyTypes
unknown file: error: SEH exception with code 0xc0000005 thrown in the test
body.
Stack trace:
[ FAILED ] TestPivotKernel.BinaryKeyTypes (1 ms)
[ RUN ] TestPivotKernel.IntegerKeyTypes
unknown file: error: SEH exception with code 0xc0000005 thrown in the test
body.
Stack trace:
[ FAILED ] TestPivotKernel.IntegerKeyTypes (1 ms)
[ RUN ] TestPivotKernel.Numbers
unknown file: error: SEH exception with code 0xc0000005 thrown in the test
body.
Stack trace:
[ FAILED ] TestPivotKernel.Numbers (1 ms)
[ RUN ] TestPivotKernel.Binary
unknown file: error: SEH exception with code 0xc0000005 thrown in the test
body.
Stack trace:
[ FAILED ] TestPivotKernel.Binary (0 ms)
[ RUN ] TestPivotKernel.NullType
unknown file: error: SEH exception with code 0xc0000005 thrown in the test
body.
Stack trace:
[ FAILED ] TestPivotKernel.NullType (0 ms)
[ RUN ] TestPivotKernel.NullValues
unknown file: error: SEH exception with code 0xc0000005 thrown in the test
body.
Stack trace:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
