davidhcoe commented on PR #2916: URL: https://github.com/apache/arrow-adbc/pull/2916#issuecomment-2987727683
I was doing make <x>.dll from Matt’s branch. ________________________________ From: David Li ***@***.***> Sent: Wednesday, June 18, 2025 11:49:20 PM To: apache/arrow-adbc ***@***.***> Cc: David Coe ***@***.***>; Mention ***@***.***> Subject: Re: [apache/arrow-adbc] fix(go/adbc/driver): inject version to built Go drivers (PR #2916) [https://avatars.githubusercontent.com/u/327919?s=20&v=4]lidavidm left a comment (apache/arrow-adbc#2916)<https://github.com/apache/arrow-adbc/pull/2916#issuecomment-2986594145> Ah, it's because the CMake version is getting injected in. I'm guessing David Coe is building off of a fork of v1.6.0 or has local changes - then it would combine the v1.6.0 in CMakeLists.txt with -dev since the worktree is apparently dirty. — Reply to this email directly, view it on GitHub<https://github.com/apache/arrow-adbc/pull/2916#issuecomment-2986594145>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADFTVNIHKXUTVTK737FP4FL3EI6NBAVCNFSM6AAAAAB6OATSOWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSOBWGU4TIMJUGU>. You are receiving this because you were mentioned.Message ID: ***@***.***> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
