CurtHagenlocher commented on code in PR #2960:
URL: https://github.com/apache/arrow-adbc/pull/2960#discussion_r2157395500
##########
csharp/src/Drivers/Apache/Hive2/HiveServer2Statement.cs:
##########
@@ -396,9 +397,9 @@ protected virtual async Task<QueryResult>
GetCrossReferenceAsForeignTableAsync(C
null,
null,
null,
- EscapeUnderscoreInName(CatalogName),
- EscapeUnderscoreInName(SchemaName),
- EscapeUnderscoreInName(TableName),
+ (CatalogName),
+ (SchemaName),
+ (TableName),
Review Comment:
Was this supposed to be changed to `EscapePatternWildcardsInName` or does
this Thrift API not work with wild cards? If the latter, then please remove the
parens from the arguments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]