birschick-bq commented on code in PR #2847: URL: https://github.com/apache/arrow-adbc/pull/2847#discussion_r2157726848
########## csharp/src/Apache.Arrow.Adbc/Tracing/SemConv.cs: ########## @@ -0,0 +1,76 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under one or more +* contributor license agreements. See the NOTICE file distributed with +* this work for additional information regarding copyright ownership. +* The ASF licenses this file to You under the Apache License, Version 2.0 +* (the "License"); you may not use this file except in compliance with +* the License. You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ + +namespace Apache.Arrow.Adbc.Tracing +{ + public static class SemConv Review Comment: This is taken from the OTel naming convention. I've expanded it to the full name: `SemanticConventions`. Let me know if this seems appropriate to you. Thanks. ########## csharp/src/Apache.Arrow.Adbc/Tracing/SemConv.cs: ########## @@ -0,0 +1,76 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under one or more +* contributor license agreements. See the NOTICE file distributed with +* this work for additional information regarding copyright ownership. +* The ASF licenses this file to You under the Apache License, Version 2.0 +* (the "License"); you may not use this file except in compliance with +* the License. You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ + +namespace Apache.Arrow.Adbc.Tracing +{ + public static class SemConv + { + public const string Namespace = "db.namespace"; + + public static class Db + { + public static class Client + { + public static class Connection + { + public const string State = "db.client.connection.state"; + public const string SessionId = "db.client.connection.session_id"; + } + } + + public static class Collection + { + public const string Name = "db.collection.name"; + } + + public static class Operation + { + public static string Parameter(string name) + { + return $"db.operation.parameter.{name}"; + } + public const string OperationId = "db.operation.operation_id"; + } + + public static class Query + { + public static string Parameter(string name) + { + return "db.query.parameter" + name; Review Comment: This is taken from the OTel naming convention. I've expanded it to the full name: `SemanticConventions`. Let me know if this seems appropriate to you. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
